Skip to content

Conversation

weyert
Copy link
Contributor

@weyert weyert commented Sep 7, 2019

Fixed the unit test in the @testing-library bit of the page as Welcome to React is not being used in the App.js.

Made the change in newly created CRA app and ran the tests in Gitlab CI:

$ react-scripts test
PASS src/App.test.js
  ✓ renders welcome message (82ms)

Fixed the  unit test in the @testing-library bit of the page as Welcome to React is not being used in the `App.js`
@weyert weyert requested review from amyrlam and iansu as code owners September 7, 2019 22:25
@iansu iansu added this to the 3.1.2 milestone Sep 9, 2019
@iansu iansu merged commit 0f9e350 into facebook:master Sep 9, 2019
@iansu
Copy link
Contributor

iansu commented Sep 9, 2019

Thanks!

VasilyShelkov pushed a commit to VasilyShelkov/create-react-extension that referenced this pull request Sep 9, 2019
@lock lock bot locked and limited conversation to collaborators Sep 14, 2019
@weyert weyert deleted the patch-1 branch November 24, 2019 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants